ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Conor MacNeill <>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/perforce P4Integ
Date Mon, 14 Jul 2003 23:32:46 GMT
On Tue, 15 Jul 2003 08:19 am, Antoine Levy-Lambert wrote:
> Re - Perforce optional tasks & checkstyle
> After having done these changes (mostly whitespace changes, lines over 100
> chars and javadoc) there remain a number of protected or public instance
> variables which should be private.
> I wonder whether we should break the API to make the code stick to the
> rules ?

No. We value compatibility over conformance to style. Once the number of 
violations goes down, I will probably relax some rules for parts of the 
codebase (see the current exceptions). Also Checkstyle will allow for more 
fine grained control of rules to files in the future, I'm told.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message