ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs DefaultExcludesTest.java DemuxOutputTask.java
Date Thu, 17 Jul 2003 13:21:07 GMT
On Thu, 2003-07-17 at 13:49, Antoine Levy-Lambert wrote:
> The class TokenFilter.LineTokenizer (written by Peter Reilly) is the tool
> which allows to read input line by line including the original line ending.
> 
> Actually, I wonder whether this class (LineTokenizer) should not be in its
> own .java file to give it more visibility. Suggestion about the appropriate
> package ( org.apache.tools.ant.util ?) and name (I think LineTokenizer is
> very expressive, I would retain this).

LineTokenizer (and its Interface Tokenizer) should go into 
org.apache.tools.ant.util.

The other tokenizers (FileTokenizer and StringTokenizer) are a bit
more problematic:
   FileTokenizer - to trivial for org.apache.tools.ant.util
   StringTokenizer - name clashes with java.util.StringTokenizer

Peter



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message