ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java defaults.properties
Date Tue, 22 Apr 2003 15:44:36 GMT
On Sat, 19 Apr 2003, Antoine Levy-Lambert <levylambert@tiscali-dsl.de>
wrote:

> I have coded the calls to the getters of ZipFileSet similarly to the
> getters of FileSet or AbstractFileSet in Zip.java.

They are the way they look right now because FileSet is much older
than ProjectComponent and thus didn't have project instance (same for
Path, BTW).

> Can we safely to change all the getters of AbstractFileSet

As long as you keep the old method signatures (of released code, that
is) for backwards compatibility, probably yes, but ...

> From: "Conor MacNeill" <conor@cortexebusiness.com.au>
>
>> Hmmm, it may even be a different project instance.

is something to consider.  I don't think we are testing a scenario
where a fileset gets inherited by a subbuild thoroughly, if at all -
still we may get away with the help of clone() that is performed in
Ant.java.

Stefan

Mime
View raw message