ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 18476] - copy with filtering modifies lineendings
Date Tue, 22 Apr 2003 23:35:36 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18476>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18476

copy with filtering modifies lineendings





------- Additional Comments From peter.reilly@corvil.com  2003-04-22 23:35 -------
snap!
I was just about to submit the changes under windows.

I have added a new patch against current cvs to fix
the unit tests and to provide an alternative fix for stripjavacomments.

The patched files are:
src/etc/testcases/filters/head-tail.xml:
  add the targets for the filterreader tests
src/testcases/org/apache/tools/ant/filters/HeadTailTest.java
  fix the result and expected filenames, I had them mixed up
  before, and the test succeeded as two non-existant files were matched
src/main/org/apache/tools/ant/filters/StripJavaComments.java
  I initially had the same logic as your fix, but realized that
  the code would not work under mac line endings. Looking at the
  code, I released that \r, or \n where all that is needed to terminate
  the the \\ comment - tested this on windows.

Cheers,
  Peter.

PS. I have had difficulty in getting the following unit tests to work on
windows:
   CopyTest - trancoding test - result not as expected
   ZipTest  - last test - unable to delete a file
   XMLCatalogTest - most of the tests fail
   FileUnitTests - to/from uri and testRemoveLeadingPath
Peter

Mime
View raw message