ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors ExtendSelector.java
Date Tue, 22 Apr 2003 10:10:18 GMT
On Tuesday 15 April 2003 01:05, Conor MacNeill wrote:
> I have some questions about this patch
>
> On Tue, 15 Apr 2003 03:21 am, umagesh@apache.org wrote:
> >   +            Project.setProjectOnObject(project, o);
>
> Why is this a static method rather than a plain method like this:
> 	project.setProjectOnObject(o);
>

To save typing if (project != null) ....

> Why don't we define an interface for all things that can have a Project
> instance (Projectable :-)) rather than using reflection? It could be
> applied to ProjectComponent.

Yes, but TaskAdaptor uses reflection to check if the adapted
class contains the setProject method. This patch was meant to
maintain this behaviour.

Peter



Mime
View raw message