ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 18613] - setproject not called for all created objects
Date Thu, 03 Apr 2003 17:28:06 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18613>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18613

setproject not called for all created objects





------- Additional Comments From peter.reilly@corvil.com  2003-04-03 17:28 -------
On reviewing the patch I found the following issues:

1) if the object that setproject is called on is not a public scoped object
   but does contain a public setproject method, the setproject method
   method is not found by getmethod. To work around this, the
   Project.setProjectOnObject() method now checks it the object extends
   ProjectComponent and if so calls setProject on a casted object - this
   should make the code functionally backward compatible

2) The same issue occuried in ChainReaderHelper. Also in this class, the
   setProject needs to be called in more places so a new private method
   method was added. Also I removed a needless check on the type of
   object in the filterchain being a Reader and ChainableReader, the
   code uses the object as a factory to create a reader.

A new patch follows...

Mime
View raw message