From ant-dev-return-35490-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org Thu Jul 11 07:49:15 2002 Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 99789 invoked from network); 11 Jul 2002 07:49:13 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 11 Jul 2002 07:49:13 -0000 Received: (qmail 26302 invoked by uid 97); 11 Jul 2002 07:49:35 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 26286 invoked by uid 97); 11 Jul 2002 07:49:34 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 26274 invoked by uid 98); 11 Jul 2002 07:49:34 -0000 X-Antivirus: nagoya (v4198 created Apr 24 2002) Message-ID: <3D2D3859.9060908@apache.org> Date: Thu, 11 Jul 2002 09:48:41 +0200 From: Nicola Ken Barozzi Reply-To: nicolaken@apache.org Organization: Apache Software Foundation User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.0) Gecko/20020530 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ant Developers List Subject: Re: enhancement, it's done, but do you like how it works? References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N dion@multitask.com.au wrote: > Nicola Ken Barozzi wrote on 07/11/2002 05:00:18 PM: > > >>As you may have seen, the import tag patch now supports redefining >>targets :-) >> >>Suppose this target: >> >> >> >>is in a file that is imported by my buildfile. >> >>With the patch I can redefine it as follows: >> >> >> >> > > > Is super.mytarget a 'special' keyword? Given that you're 'redefining' that > target (mytarget), what does antcalling it do? This is confusing IMHO for > an end user. Hmmm... It works like in java. super. is a special prefix. If I redefine mycooltarget two times I can call the first version via super.super.mycooltarget , and the second version super.mycooltarget . Any suggestions on how it can be made better? >> >> >> >> >>Now, mytarget currently does *not* inherit dependencies, although, >>having used the same name, it will effectively replace the old version >>in the graph. > > Not inheriting dependencies vs inheriting them should really be a non > issue. Either it replaces the old one completely or it doesn't, would be > my take. ? It replaces it for sure, but dependencies are part of the old behaviour. Other targets see the new one as the old one (replaces), but the new one doesn't automatically depend on the targets the old one depended on. >>This is the order in which the targets are called, also with the outcome >>in case we enable dependency inheritance: >> >> 1 original mytarget: a->b->c->dostuff >> 2 redefined mytarget: dostuff1->a->b->c->dostuff->dostuff2 > > Makes sense. > >> 3 dependency inherit: a->b->c->dostuff1->dostuff->dostuff2 > > Doesn't make sense. I think so too. >>IMHO (2) would be the outcome that users think comes out. >> >>What do you think? > > Yip. :-D -- Nicola Ken Barozzi nicolaken@apache.org - verba volant, scripta manent - (discussions get forgotten, just code remains) --------------------------------------------------------------------- -- To unsubscribe, e-mail: For additional commands, e-mail: