ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dona...@apache.org
Subject cvs commit: jakarta-ant-myrmidon/container/src/java/org/apache/myrmidon/components/executor AspectAwareExecutor.java
Date Tue, 23 Apr 2002 07:35:44 GMT
donaldp     02/04/23 00:35:44

  Modified:    container/src/java/org/apache/myrmidon/components/executor
                        AspectAwareExecutor.java
  Log:
  Renamed doExecute to doTaskExecute for clarity
  
  Removed LogEnabled stage as lifecycle stage
  
  renamed execute to doExecute so that can inherit event propogation behaviour from DefaultExecutor
  
  Revision  Changes    Path
  1.27      +6 -10     jakarta-ant-myrmidon/container/src/java/org/apache/myrmidon/components/executor/AspectAwareExecutor.java
  
  Index: AspectAwareExecutor.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant-myrmidon/container/src/java/org/apache/myrmidon/components/executor/AspectAwareExecutor.java,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- AspectAwareExecutor.java	21 Apr 2002 01:54:28 -0000	1.26
  +++ AspectAwareExecutor.java	23 Apr 2002 07:35:44 -0000	1.27
  @@ -12,7 +12,6 @@
   import java.util.Properties;
   import org.apache.avalon.excalibur.i18n.ResourceManager;
   import org.apache.avalon.excalibur.i18n.Resources;
  -import org.apache.avalon.framework.logger.Logger;
   import org.apache.avalon.framework.service.ServiceException;
   import org.apache.avalon.framework.service.ServiceManager;
   import org.apache.avalon.framework.service.Serviceable;
  @@ -28,7 +27,7 @@
    * the aspects helpers.
    *
    * @author <a href="mailto:peter@apache.org">Peter Donald</a>
  - * @version $Revision: 1.26 $ $Date: 2002/04/21 01:54:28 $
  + * @version $Revision: 1.27 $ $Date: 2002/04/23 07:35:44 $
    */
   public class AspectAwareExecutor
       extends DefaultExecutor
  @@ -53,7 +52,8 @@
           m_aspectManager = (AspectManager)serviceManager.lookup( AspectManager.ROLE );
       }
   
  -    public void execute( final ModelElement taskModel, final ExecutionFrame frame )
  +    protected void doExecute( final ModelElement taskModel,
  +                              final ExecutionFrame frame )
           throws TaskException
       {
           try
  @@ -84,10 +84,6 @@
               final Task task = doCreateTask( taskName, frame );
               getAspectManager().postCreate( task );
   
  -            debug( "logger.notice", taskName );
  -            final Logger logger = frame.getLogger();
  -            getAspectManager().preLogEnabled( logger );
  -
               debug( "contextualizing.notice", taskName );
               final TaskContext context = doCreateContext( frame );
               doContextualize( task, taskModel, context, frame );
  @@ -98,7 +94,7 @@
   
               debug( "executing.notice", taskName );
               getAspectManager().preExecute();
  -            doExecute( taskModel, task );
  +            doTaskExecute( taskModel, task );
               getAspectManager().preDestroy();
           }
           catch( Exception e )
  @@ -111,8 +107,8 @@
           }
       }
   
  -    protected void doExecute( final ModelElement taskModel,
  -                              final Task task )
  +    protected void doTaskExecute( final ModelElement taskModel,
  +                                  final Task task )
           throws TaskException
       {
           task.execute();
  
  
  

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message