From ant-dev-return-24339-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org Sat Feb 02 14:22:38 2002 Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 95346 invoked from network); 2 Feb 2002 14:22:38 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 2 Feb 2002 14:22:38 -0000 Received: (qmail 18759 invoked by uid 97); 2 Feb 2002 14:22:34 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 18743 invoked by uid 97); 2 Feb 2002 14:22:34 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 18732 invoked from network); 2 Feb 2002 14:22:33 -0000 Message-Id: <200202021422.g12EMVE06857@mail016.syd.optusnet.com.au> Content-Type: text/plain; charset="utf-8" From: Peter Donald To: "Ant Developers List" Subject: Re: cvs commit: jakarta-ant/proposal/myrmidon/src/testcases/org/apache/myrmidon/components/deployer DefaultDeployerTest.java TestConverter1.java TestType1.java Date: Sun, 3 Feb 2002 01:16:42 +1100 X-Mailer: KMail [version 1.3.2] References: <20020202125159.27054.qmail@icarus.apache.org> In-Reply-To: <20020202125159.27054.qmail@icarus.apache.org> X-Wisdom-Cookie: . MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sat, 2 Feb 2002 23:51, adammurdoch@apache.org wrote: > /** > * A general-purpose type definition. > * > * @author Adam Murdoch > */ > public class GeneralTypeDefinition > extends TypeDefinition > { > private String m_name; vs > public abstract class TypeDefinition > { Is there any need to separate out the above two classes? From the looks of things - no - but is there something else you have in mind? > /** > * A base class for tests for the default components. > * > * @author Adam Murdoch > */ > public class ComponentTestBase extends TestCase Do you want to rename this to AbstractComponentTest because that fits in with the naming patterns of swing (which is consistent with the rest of the myrmidon codebase). -- Cheers, Pete -------------------------------- My opinions may have changed, but not the fact that I am right -------------------------------- -- To unsubscribe, e-mail: For additional commands, e-mail: