From ant-dev-return-26796-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org Thu Feb 28 17:00:12 2002 Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 71884 invoked from network); 28 Feb 2002 17:00:11 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 28 Feb 2002 17:00:11 -0000 Received: (qmail 26365 invoked by uid 97); 28 Feb 2002 16:59:54 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 26297 invoked by uid 97); 28 Feb 2002 16:59:53 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 26256 invoked from network); 28 Feb 2002 16:59:53 -0000 Message-ID: <014801c1c079$5658cac0$270610ac@manu.com> From: "Magesh Umasankar" To: "Ant Developers List" References: Subject: Re: [VOTE] Promotion of FilterReaders proposal to main development tree. Date: Thu, 28 Feb 2002 11:59:50 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-Spam-Rating: localhost.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N From: > On Thu, 28 Feb 2002, Magesh Umasankar wrote: > > > > Not if you first declare "striplinecomments" as a type, using > > > a typedef declaration ( or antlib ). > > > > > > > How will I be able to extend from java.ioFilterReader > > as well as DataType at the same time? > > You don't have to - again, TaskAdapter ( or RoleAdapter in > proposal ) will do the magic. ( well, you > need a TypeAdapter equivalent with TaskAdapter ). > I'm working on a generic solution based on RoleAdapter > and TaskFactory, but even if this is not accepted, > RoleAdapter in antlib or a trivial cut&paste from > TaskAdapter will solve this - not only for FilterReader > but for anything else. > > Plugging a bean into ant shouldn't require > extending DataType or Task - just by implementing the > ant patterns and letting ant do the adaptation. > Once makes its way in, will become extinct, ok? > > > Also, note one of my aims was to be able to write > > a pluggable filterreader that has been created > > without making use of any of Ant's APIs... I don't > > know how _important_ it is for this rule to > > stay, but if it stays, it will be more convenient... > > Yes, this is very _important_ for me too. > cool :-) > > > > The class would have to follow ant's patterns - i.e. have > > > addComment(), etc - like a task ( or a TaskAdapter-ed task ) > > > would. > > > > It already does so that it can be used > > in short form notation too. That is, > > > > ... > > > > can also be written as > > > > ... > > > > Why do you need the first form ? It's ugly, doesn't follow the > ant patterns, etc. We don't have . > The first form is not needed currently. FilterChain recognizes elements added using . However, not all filterreaders that are created by users will be recognized by FilterChain. For such filterreaders, user would use (or when available) syntax. The first form is just an _example_ to illustrate that striplinecomments, though it has a convenient form, is a generic filterreader just like the user's. The first form does follow ant patterns - checkout . > The real problem is that you don't have enough power in > and TypeAdapter - but it's better to solve the > real problem instead of doing a workaround. As I said, I am not opposing getting this solved in a generic way. The element inside is being used just to get around Ant's current limitations, just like , etc. > > > There are enough proposals already ;-) > > I will just wait till something surfaces > > and I will use it. Till then, look at > > as another motivation > > for ;-) > > I would reverse it - look at my comments on filterreader > as a motivation for you to get involved in > or just the adapter part. Are you against the proposal being put into the main trunk _before_ gets there? > > Costin > Cheers, Magesh ************************************************* * Committee: Individuals who can do nothing * * individually and sit to decide that nothing * * can be done together. * ************************************************* -- To unsubscribe, e-mail: For additional commands, e-mail: