ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] /src/main/org/apache/tools/ant/IntrospectionHelper.java (More JavaDocs)
Date Wed, 20 Feb 2002 10:17:01 GMT
On Tue, 19 Feb 2002, Jon Skeet <jon.skeet@peramon.com> wrote:

> Requested clarification in constructor documentation and manual
> (addConfigured)

Yep, I'm sure it is burried somewhere done on Conor's list (and it is
on mine as well, which doesn't mean I want to do it 8-).

The difference between addConfiguredX and addX is that addConfiguredX
will hand out the Object after the setters on this Object have been
called while addX will be called before the child elements gets
configured.

> Why does storeElement return on null elementName / NestedStorer,
> where other methods will throw an exception?

In the case of elementName - I don't know.  Conor, you should add an
author tag for yourself.

In the case of NestedStorer, this is because ProjectHelper will call
createElement before it calls storeElement, the excecption would have
been thrown their anyway.  Furthermore ProjectHelper will call
storeElement even if the nested element was handled by createX or addX
methods that don't have NestedStorers associated to them.

> Commented on implementation of createAttributeSetter - can be made
> much simpler (although slightly slower).

I agree with your comments.

> getElementName could be made static, which would add some clarity
> (IMO).

Not sure why it would add clarity, maybe it should be moved to the
Project class instead?

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message