ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Skeet" <jon.sk...@peramon.com>
Subject [PATCH] /src/main/org/apache/tools/ant/IntrospectionHelper.java (More JavaDocs)
Date Tue, 19 Feb 2002 16:33:25 GMT
Just the one class today, 'cos it was a biggie :)

Notes:

Requested clarification in constructor documentation and manual
(addConfigured)

Changed a couple of parameter names for clarity (element->parent in both
cases, IIRC).

Why does storeElement return on null elementName / NestedStorer,
where other methods will throw an exception?

Commented on implementation of createAttributeSetter - can be made
much simpler (although slightly slower).

getElementName could be made static, which would add some clarity
(IMO).

The various one-method interfaces haven't been documented in detail, as
they
ended up reducing code readability.

Jon

Mime
View raw message