From ant-dev-return-23640-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org Fri Jan 25 21:06:17 2002 Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 6464 invoked from network); 25 Jan 2002 21:06:16 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 25 Jan 2002 21:06:16 -0000 Received: (qmail 27264 invoked by uid 97); 25 Jan 2002 21:06:16 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 27232 invoked by uid 97); 25 Jan 2002 21:06:15 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 27219 invoked from network); 25 Jan 2002 21:06:15 -0000 Message-Id: <200201252106.g0PL6EE16292@mail016.syd.optusnet.com.au> Content-Type: text/plain; charset="utf-8" From: Peter Donald To: "Ant Developers List" Subject: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/i18n Translate.java Date: Sat, 26 Jan 2002 07:28:28 +1100 X-Mailer: KMail [version 1.3.2] References: <20020125150506.68997.qmail@icarus.apache.org> <02a201c1a5b5$60bedfb0$6401a8c0@darden.virginia.edu> In-Reply-To: <02a201c1a5b5$60bedfb0$6401a8c0@darden.virginia.edu> X-Wisdom-Cookie: . MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sat, 26 Jan 2002 02:31, Erik Hatcher wrote: > ----- Original Message ----- > From: > > > --- Checksum.java 8 Jan 2002 20:14:46 -0000 1.8 > > +++ Checksum.java 25 Jan 2002 15:05:06 -0000 1.9 > > @@ -129,55 +129,55 @@ > > /** > > * Sets the file for which the checksum is to be calculated. > > */ > > - public void setFile(File file) { > > - this.file = file; > > + public void setFile(File aFile) { > > + this.file = aFile; > > } > > I'm not fond of this change.... this means that the Javadoc will show the > parameter as "aFile" rather than "file". > > I understand the rationale to making the method attribute different from > the member variable, although my style is still to leave them the same. I > think the prefixed underscores for private member variables is perhaps a > better scheme. Anyway, I think the outward interface and documentation is > more important than the internal naming conventions. I agree - but for a different reason. IDEA uses the names of variables as hints when extracting exressions/variables/so forth. Thus that would defult to using aFile in extracted name which is a bit icky ;) -- Cheers, Pete "Man's mind stretched to a new idea never goes back to its original dimensions." -Oliver Wendell Holmes -- To unsubscribe, e-mail: For additional commands, e-mail: