From ant-dev-return-22537-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org Tue Jan 08 09:35:21 2002 Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 23558 invoked from network); 8 Jan 2002 09:35:21 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 8 Jan 2002 09:35:21 -0000 Received: (qmail 27473 invoked by uid 97); 8 Jan 2002 09:34:09 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 27186 invoked by uid 97); 8 Jan 2002 09:34:01 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 26756 invoked from network); 8 Jan 2002 09:33:57 -0000 Message-Id: <200201080933.g089Xtr27999@mail004.syd.optusnet.com.au> Content-Type: text/plain; charset="utf-8" From: Peter Donald To: "Ant Developers List" Subject: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/types E numeratedAttribute.java Date: Tue, 8 Jan 2002 19:53:14 +1100 X-Mailer: KMail [version 1.3.2] References: <9B3E950CB293D411ADF4009027B0A4D202A693A8@maileu.imediation.com> In-Reply-To: <9B3E950CB293D411ADF4009027B0A4D202A693A8@maileu.imediation.com> X-Wisdom-Cookie: . MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Tue, 8 Jan 2002 19:29, Stephane Bailliez wrote: > I'm just saying that even if I fully agree with this, this sudden > 'guideline' is all of a 'sudden' and has never been part of the Ant > guidelines which do not exist at all AFAIK. So I'm just wondering why this > is suddenly emerging when there has been lengthy talk about how dead was > the Ant 1.x code. Better late than never ;) > I'm totally 150% OK for this but I'd would also like us to focus on having > the code cleaned up to be homogeneous and respect the Jakarta coding lines > especially considering braces, indentation and naming. There has been > lengthy debate about this on general and commons about how anarchic was > starting to be the code in Jakarta and even though in Ant a lot of code has > been done by non-committers this does not prevent us from having severe > guidelines and respect them. Not really viable to cleanup the majority of stuff due to backwards compatability. We can clean it for Ant2 and I have been gradually doing this in the myrmidon proposal but it is just not justifiable in Ant1.x ;( > If we do this then we have to be more responsive about user willing to > integrate Ant. > For instance I think we did not take much in account the critics from Jeff > McGuire about integrating Ant w/ Eclipse. Sorry - I missed them - do you have a link ;) > For the sake of clarity and so that it is crystal-clear I will commit a > document about these coding guidelines ASAP as a starting point. Comments ? If you want but I think we should leave of till Ant2 to try an enforce it or anything and I think it should focus less on typographic features and more on making things easier to evolve -- Cheers, Pete --------------------------------------------------- Murphy's law - "Anything that can go wrong, will." (Actually, this is Finagle's law, which in itself shows that Finagle was right.) --------------------------------------------------- -- To unsubscribe, e-mail: For additional commands, e-mail: