----- Original Message -----
From: <umagesh@apache.org>
> --- Checksum.java 8 Jan 2002 20:14:46 -0000 1.8
> +++ Checksum.java 25 Jan 2002 15:05:06 -0000 1.9
> @@ -129,55 +129,55 @@
> /**
> * Sets the file for which the checksum is to be calculated.
> */
> - public void setFile(File file) {
> - this.file = file;
> + public void setFile(File aFile) {
> + this.file = aFile;
> }
I'm not fond of this change.... this means that the Javadoc will show the
parameter as "aFile" rather than "file".
I understand the rationale to making the method attribute different from the
member variable, although my style is still to leave them the same. I think
the prefixed underscores for private member variables is perhaps a better
scheme. Anyway, I think the outward interface and documentation is more
important than the internal naming conventions.
Thoughts?
Erik
--
To unsubscribe, e-mail: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
|