ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran" <stev...@iseran.com>
Subject Re: [PATCH] ejb-jar/jonas element again
Date Thu, 27 Dec 2001 01:41:11 GMT

----- Original Message -----
From: "Cyrille Morvan" <cyrille_list@ingenosya.com>
To: <ant-dev@jakarta.apache.org>
Sent: Wednesday, December 26, 2001 2:48 AM
Subject: [PATCH] ejb-jar/jonas element again


> Hello again !
>
> I sended my patch two times : a few weeks ago and a few days ago.
>
> I will send my files until they will be commited or a someone gives a good
> reason to not do it !
>
> There is a JBoss version of the DeploymentTool and Ant must have a JOnAS
> version !
>
>
> Thank you.
>

well, it is the xmas week and everyone is away. So no, you shouldnt have
expected anything to have happened over this week.

Regarding why you hadnt heard anything since last time, well, I guess that
meant nobody else on ant-dev had been using JOnAS, so there was nobody ready
to pick up your app and play with it. We prefer to have broader experience
and maybe even some test cases before committing something, because it then
becomes our support problem.

We do need somebody else to play with this before I am happy commiting it,
even though I agree that a jonas task would be a worthy addition to Ant -or
the JOnAS codebase.

I had been a bit concerned about the fact that JOnAS is
GPL, and we cant have GPL code in the Apache source tree, but since you are
only calling it via a <java> call I think we should be ok on that. Correct?

So the primary issue is that it'd be nice to get some input from other JOnAS
users. If we dont, well, we could commit it and then field the feedback
which will come in. Like most optional tasks which arent testable on most
systems its hard to keep these tasks alive without the involvement of the
original author and users.

Before we get that far, there are some bits in the code that, while
workable, are not really what we want in the codebase:

line 160: setVerbose(), 158 setNoGENIC etc.
-use boolean as an argument, not string. Ant will do the conversion for you
and support "yes" and "no" as well as "true" and "false"


line 359: getTask().getProject().copyFile(inSourceJar, inDestJar);
-use FileUtils instead

line 198: setOuputdir, line 216 setWorkDir.
-please be consistent with other tasks which use destDir as the
destination directory. There is now special support for a DestDir datatype
and a setDestDir(DestDir destdir) method, which hands off all the validation
to ant, rather than your task.

lines 294-302
-why are you faffing around with string replacing and searches to find the
parent directory and file name element, why not just use File.getName() and
File.getParent()?

So, why not make the changes, add a junit test class which stresses the task
and start harassing us a week or so into January, when people are back from
their holidays.

-steve



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message