You are quite right on the chdir stuff. I think there was a problem with the chdir command
on NetWare, and I forgot to ever put it back in during the non-NetWare case. I'll rework
this.
Yeah, I found out that Exec.java was not used, after I ported that part. I also somehow forgot
to port Execute.java. I found that out later and have been working on it. I even think that
I've got something working, but dad blast it, there is no exec test, so it is hard to prove.
Being a relative newbie to Ant, I do not know the semantics of the <exec> task, and
so I haven't even got a build script to exercise it.
My execute.java is a little bit different than the example that you put, though it is along
the same lines. One problem on NetWare is that I need to enter the "perl" command before
the fully qualified script name, so "perl sys:/ant/bin/antRun.pl". I had decided to use
a "PerlScriptCommandLauncher", which is not too different than a ScriptCommandLauncher, except
that it prefixes the command with "perl ".
I hadn't submitted that yet because of lack of tests to prove if it is working correctly.
Jeff Tulley (jtulley@novell.com)
(801)861-5322
Novell, Inc., the leading provider of Net services software.
>>> bodewig@apache.org 11/14/01 2:41:57 AM >>>
Hi Jeff,
I noticed you've commented out the chdir call in the script - is that
intended?
You seem to prefix the directory to the command to execute, this is
not what antRun does - there is a difference between
cd /tmp
ls
and
/tmp/ls
at least in most situations 8-)
I guess I'm simply not understanding the script, which may very well
be as my Perl has become more than a little rusty.
Also, I just now realized that your first patches applied to Exec.java
- this file isn't used anywhere anymore, <exec> corresponds to
ExecTask.java which in turn uses Execute.java, I guess you want to do
something like the attached patch.
Stefan
Index: src/main/org/apache/tools/ant/taskdefs/Execute.java
===================================================================
RCS file: /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Execute.java,v
retrieving revision 1.24
diff -u -r1.24 Execute.java
--- src/main/org/apache/tools/ant/taskdefs/Execute.java 2001/11/02 07:56:52 1.24
+++ src/main/org/apache/tools/ant/taskdefs/Execute.java 2001/11/14 09:29:08
@@ -119,6 +119,11 @@
// OS/2 - use same mechanism as Windows 2000
shellLauncher = new WinNTCommandLauncher(new CommandLauncher());
}
+ else if ( Os.isFamily("netware") ) {
+ // Novell Netware - use the Perl script
+ shellLauncher = new ScriptCommandLauncher("bin/antRun.pl",
+ new CommandLauncher());
+ }
else if ( Os.isFamily("windows") ) {
// Windows. Need to determine which JDK we're running in
--
To unsubscribe, e-mail: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
--
To unsubscribe, e-mail: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
|