ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] JUnitTask.java / XMLJUnitResultFormatter.java
Date Wed, 11 Jul 2001 09:10:44 GMT
On Mon, 18 Jun 2001, Erik Hatcher <erikhatcher@earthlink.net> wrote:

> I've made the changes to JUnitTestRunner.java, JUnitTask.java, and
> JUnitTest.java to handle forked <junit> tests.

will be committed in a few minutes.

> I've attached a file with the CVS diff's (again, let me know if this
> is not a usable format).

Please use unified (-u) diffs next time.  I had to manually move
around you changed code as the source files had been changed already.
Also, please use an indent level of four spaces (no tabs) please and
make sure your code compiles under JDK 1.1 (Properties.putAll()),
thanks.

> Also, I've added myself as an author tag on a few of the files (all
> but one, where I only modified a few lines of code).  I'm not sure
> what the rules are with that, but if I'm under the number of lines
> of code to deserve that tag, my feelings won't be hurt if you take
> it off!  :)

I don't think we have some strong rules here, I have never removed or
added author lines from/to patches that have been sent in.

Stefan

Mime
View raw message