ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 2652] - Subclasses of Project can not load datatypes.
Date Tue, 17 Jul 2001 22:49:14 GMT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=2652

*** shadow/2652	Tue Jul 17 11:15:47 2001
--- shadow/2652.tmp.771	Tue Jul 17 15:49:14 2001
***************
*** 32,35 ****
  ------- Additional Comments From jesse.glick@netbeans.com  2001-07-17 11:15 -------
  I don't think you need to subclass Project, at least not necessarily:
  
! http://www.netbeans.org/source/browse/ant/src/org/apache/tools/ant/module/run/TargetExecutor.java?rev=1.9&content-type=text/x-cvsweb-markup
--- 32,51 ----
  ------- Additional Comments From jesse.glick@netbeans.com  2001-07-17 11:15 -------
  I don't think you need to subclass Project, at least not necessarily:
  
! http://www.netbeans.org/source/browse/ant/src/org/apache/tools/ant/module/run/TargetExecutor.java?rev=1.9&content-type=text/x-cvsweb-markup
! 
! ------- Additional Comments From robert.watkins@qsipayments.com  2001-07-17 15:49 -------
! In CruiseControl, we've used a subclass of Project to get around the fact that 
! all of the event-notification APIs are protected (which is odd, as all the 
! event notification is done by outside classes, not self-triggered). As we have 
! multiple build listeners involved, we preferred to use the internal 
! notification, not an externally imposed one.
! 
! Further more, there's a slight change in behaviour, in that we've added a clean-
! up method. The subclass thus was the preferred option.
! 
! As Project is not final, it should be okay to subclass it, and Project should 
! take that into account. It's a fairly small change, after all.
! 
! As mentioned in the original bug report, we get around it by overriding the 
! affected method, so it's not a show-stopper.

Mime
View raw message