From ant-dev-return-11176-apmail-jakarta-ant-dev-archive=jakarta.apache.org@jakarta.apache.org Thu Mar 08 20:54:32 2001 Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@jakarta.apache.org Received: (qmail 52250 invoked by uid 500); 8 Mar 2001 20:54:22 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk Reply-To: ant-dev@jakarta.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 52102 invoked from network); 8 Mar 2001 20:54:18 -0000 From: David Rees To: ant-dev@jakarta.apache.org Subject: Re: [PATCH] Zip bug Date: Thu, 08 Mar 2001 12:45:25 -0800 Message-ID: References: In-Reply-To: X-Mailer: Forte Agent 1.8/32.548 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N On 08 Mar 2001 11:58:30 +0100, Stefan Bodewig wrote: >David Rees wrote: > >> Fixes a bug in Zip task that doesn't close source Zip files. Also >> adds tests to verify the bug and fix. > >While I'm ready to commit your changes - will happen in a few minutes >- what are the tests supposed to test? > >I think the last test is going to fail on Windows (not available here >8-) when it tries to delete inner7.zip, but what exactly are you doing >with the other testcases? Simply checking that doesn't die? > test5 tests ZipFileSets in general (they were not being tested at all) test6 tests ZipFileSets with includes and excludes. Specifically it tests something that thought looked quirky when I was looking at the code. test7 fails before my bug fix. doesn't fail after my bug fix. Verified on Windows (because that is what I have ;). d --------------------------------------------------------------------- To unsubscribe, e-mail: ant-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: ant-dev-help@jakarta.apache.org