ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Rees <>
Subject Re: [PATCH] Zip bug
Date Thu, 08 Mar 2001 20:45:25 GMT
On 08 Mar 2001 11:58:30 +0100, Stefan Bodewig wrote:

>David Rees <> wrote:
>> Fixes a bug in Zip task that doesn't close source Zip files. Also
>> adds tests to verify the bug and fix.
>While I'm ready to commit your changes - will happen in a few minutes
>- what are the tests supposed to test?
>I think the last test is going to fail on Windows (not available here
>8-) when it tries to delete, but what exactly are you doing
>with the other testcases? Simply checking that <zip> doesn't die?

test5 tests ZipFileSets in general (they were not being tested at all)

test6 tests ZipFileSets with includes and excludes. Specifically it
tests something that thought looked quirky when I was looking at the

test7 fails before my bug fix. doesn't fail after my bug fix. Verified
on Windows (because that is what I have ;).


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message