ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@bost.de>
Subject Re: [PATCH] Less memory consumption for subbuilds
Date Thu, 20 Jul 2000 14:07:10 GMT
>>>>> "CM" == Conor MacNeill <conor@m64.com> writes:

 >> From: Stefan Bodewig [mailto:bodewig@bost.de]

 >> Can anybody see a reason why we shouldn't move the whole code from
 >> init over to execute?
 >> 

 CM> The only issue would be the createProperty method. Obviously p1
 CM> must be instantiated.

Yes, of course, should have been clearer. 

p1 could be instantiated in a constructor or directly at the
declaration point as well.

 CM> I don't know if there will be any effect of setting the user
 CM> properties first.

No. If it is set first, the "normal" setProperty call will be
ignored. If it's called afterwards, the value inside the "normal"
properties get replaced by the userProperty value.

 CM> I'd also keep it as a separate method to be called from
 CM> execute().

Fear execute is getting to long? Maybe we should split it differently
then.

Stefan

Mime
View raw message